Page 1 of 6 1234 ... LastLast
Results 1 to 25 of 142
Like Tree29Likes
  1. Thread Author  Thread Author    #1  

    Default Group Text Messaging for JB - ACHIEVED!

    I have just finished testing my modifications to the framework and MMS apk to enable Group Texting similar to the iPhone.

    I am VERY new to JAVA / Android / Git / Gerrit and I am learning as I go along. I am working on submitting the code to AOSP right now but if there is anyone that would like to incorporate the modified java classes for their ROM, as soon as possible, I will gladly work with you in making that happen.

    I have modified the android-4.1.1_r4 branch from AOSP and only tested it on my own toro/GNex. I lack resources and time to test on any other device, but you are welcome to do so.
    EDIT: Also check post #13 below for changes to mmssms.db schema.

    Group Text Messaging for JB - ACHIEVED!-device-2012-09-09-224659.jpgGroup Text Messaging for JB - ACHIEVED!-device-2012-09-09-224740.jpgGroup Text Messaging for JB - ACHIEVED!-device-2012-09-09-225004.jpgGroup Text Messaging for JB - ACHIEVED!-device-2012-09-09-225016.jpgGroup Text Messaging for JB - ACHIEVED!-device-2012-09-09-225038.jpg



    changes have been committed to "jb-release" branch

    12/05/12:

    Thank you guys for your support. The community is amazing.

    I apologize for the absence. I have been putting allllll my efforts in finding a job, and have finally got one.

    A quick update:

    I was never able to get my virtual machine to play nicely with gerrit (especially Google's gerrit), but invisiblek has done me HUGE favor and submitted the code to cyanogenmod's gerrit for review.

    After a few rounds of review the gerrit patch on CM was abandon, due to the fact that the patch will be native in AOSP 4.2

    There are many 3rd party ROMS that have the patch included hopefully many more to come.

    - Vivek Vasani
    Last edited by playa1257; 12-05-2012 at 10:42 AM.
    Thanked by 13:
    + Show/Hide list of the thanked
  2. #2  
    jerseyboy357's Avatar

    Posts
    1,465 Posts
    ROM
    Liquid Smooth JB Beta 2

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Impressive Sir
    Yea, I'm still rockin' a Gnex. The signal strength/quality sucks, but hey, it's not two years old yet.
  3. #3  
    zero neck's Avatar
    The Ever-Living

    Posts
    5,090 Posts
    Global Posts
    5,097 Global Posts
    ROM
    KANG

    Default Re: Group Text Messaging for JB - ACHIEVED!

    dope, great work/\.


    * INCREDIBLE * MECHA * TORO * GROUPER * GALAXY S3 *
    * [TORO RADIOS] * [NEXUS WALLS] * [GROUPER GUIDE] * [CHATTER] *
  4. #4  
    Poseign's Avatar
    Mobile Enthusiast

    Posts
    585 Posts
    Global Posts
    601 Global Posts
    ROM
    AOKP JB B1/Franco M5

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Quote Originally Posted by playa1257 View Post
    I have just finished testing my modifications to the framework and MMS apk to enable Group Texting similar to the iPhone.

    I am VERY new to JAVA / Android / Git / Gerrit and I am learning as I go along. I am working on submitting the code to AOSP right now but if there is anyone that would like to incorporate the modified java classes for their ROM, as soon as possible, I will gladly work with you in making that happen.

    I have modified the android-4.1.1_r4 branch from AOSP and only tested it on my own toro/GNex. I lack resources and time to test on any other device, but you are welcome to do so.

    Click image for larger version. 

Name:	device-2012-09-09-224659.jpg 
Views:	1076 
Size:	17.7 KB 
ID:	36962Click image for larger version. 

Name:	device-2012-09-09-224740.jpg 
Views:	1086 
Size:	28.9 KB 
ID:	36963Click image for larger version. 

Name:	device-2012-09-09-225004.jpg 
Views:	1101 
Size:	29.8 KB 
ID:	36964Click image for larger version. 

Name:	device-2012-09-09-225016.jpg 
Views:	1138 
Size:	30.6 KB 
ID:	36965Click image for larger version. 

Name:	device-2012-09-09-225038.jpg 
Views:	1183 
Size:	40.6 KB 
ID:	36966



    changes have been committed to "jb-release" branch

    I dont understand. What you are showing is something that can already be done with the stock SMS app, unless I'm missing something here.

    EDIT: Nevermind. I think I see it now.
  5. #5  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Cool! Would love to see this baked into JB.

    How hard is it to incorporate this into a ROM?
  6. Thread Author  Thread Author    #6  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Quote Originally Posted by ohiomoto View Post
    Cool! Would love to see this baked into JB.

    How hard is it to incorporate this into a ROM?
    I can't see how it would be too hard. But I don't build ROMs, so I'm not sure. But It's essentially 10 files that I modified off Google's AOSP code. So if someone were to build a ROM off the AOSP then just have to replace those 10 files with mine.

    Otherwise, if it were another ROM, i.e. Cyanogen, Vicious, Liquid, then it would be a little more work as those ROMs have their own version of the files that need to be changed. In my first post I put a link to my GitHub account and they can just go to the "jb-release" branch and look at the commit history to see exactly WHAT code I added and WHERE to insert it into their version.
    Thanked by:
    ohiomoto likes this.
  7. #7  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    How do I get this? How do I install it?
  8. #8  
    Bobaroo's Avatar

    Posts
    154 Posts
    ROM
    AOKP M5

    Default Re: Group Text Messaging for JB - ACHIEVED!

    This needs to be in every ROM (and stock android) ASAP!!
  9. #9  
    SeigaGen's Avatar

    Posts
    624 Posts
    ROM
    Kang/CM10

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Quote Originally Posted by playa1257 View Post

    I am VERY new to JAVA / Android / Git / Gerrit and I am learning as I go along. I am working on submitting the code to AOSP right now but if there is anyone that would like to incorporate the modified java classes for their ROM, as soon as possible, I will gladly work with you in making that happen.
    And yet you have done something to the Android Messaging system that should have always been integrated! Phenomenal job!
    Motorola Droid Maxx

    Samsung Galaxy Nexus - RIP
    CM10 Jellybro Jelly Bean

    Asus Nexus 7
    AOKP JB Milestone 1
  10. #10  
    SeigaGen's Avatar

    Posts
    624 Posts
    ROM
    Kang/CM10

    Default Re: Group Text Messaging for JB - ACHIEVED!

    FYI,

    Euroskank wants to implement this, but has stated a comment you might want to look at:

    Motorola Droid Maxx

    Samsung Galaxy Nexus - RIP
    CM10 Jellybro Jelly Bean

    Asus Nexus 7
    AOKP JB Milestone 1
  11. #11  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    I spread this over to rootzwiki and looks like i've got a developer to compile a mod, thanks again playa, i will be testing it today.

    Thanked by:
  12. #12  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Link is not working kevlar924.

    EDIT: Looks like it was merged with another thread:
  13. Thread Author  Thread Author    #13  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Sorry I disappeared for a bit. Looks like the word is spreading and FAST!!

    I found a tiny annoying glitch when building a CM10 ROM with my mod. So I went on a very long hackathon with myself. Turns out that not only does the framework and Mms.apk needs to be changed but there need to be a slight change to TelephonyProvider.apk

    TelephonyProvider.apk contains: MmsSmsDatabaseHelper.java that provides the setting up and maintaining of the mmssms.db and there are triggers that are created when the database is initially created (WHICH MEANS AFTER A FULL FACTORY WIPE).

    original trigger:
    Code:
        private static final String UPDATE_THREAD_SNIPPET_SNIPPET_CS_ON_DELETE =
                            "  UPDATE threads SET snippet = " +
                            "   (SELECT snippet FROM" +
                            "     (SELECT date * 1000 AS date, sub AS snippet, thread_id FROM pdu" +
                            "      UNION SELECT date, body AS snippet, thread_id FROM sms)" +
                            "    WHERE thread_id = OLD.thread_id ORDER BY date DESC LIMIT 1) " +
                            "  WHERE threads._id = OLD.thread_id; " +
                            "  UPDATE threads SET snippet_cs = " +
                            "   (SELECT snippet_cs FROM" +
                            "     (SELECT date * 1000 AS date, sub_cs AS snippet_cs, thread_id FROM pdu" +
                            "      UNION SELECT date, 0 AS snippet_cs, thread_id FROM sms)" +
                            "    WHERE thread_id = OLD.thread_id ORDER BY date DESC LIMIT 1) " +
                            "  WHERE threads._id = OLD.thread_id; "
    I added a few lines at the end:
    Code:
        private static final String UPDATE_THREAD_SNIPPET_SNIPPET_CS_ON_DELETE =
                            "  UPDATE threads SET snippet = " +
                            "   (SELECT snippet FROM" +
                            "     (SELECT date * 1000 AS date, sub AS snippet, thread_id FROM pdu" +
                            "      UNION SELECT date, body AS snippet, thread_id FROM sms)" +
                            "    WHERE thread_id = OLD.thread_id ORDER BY date DESC LIMIT 1) " +
                            "  WHERE threads._id = OLD.thread_id; " +
                            "  UPDATE threads SET snippet_cs = " +
                            "   (SELECT snippet_cs FROM" +
                            "     (SELECT date * 1000 AS date, sub_cs AS snippet_cs, thread_id FROM pdu" +
                            "      UNION SELECT date, 0 AS snippet_cs, thread_id FROM sms)" +
                            "    WHERE thread_id = OLD.thread_id ORDER BY date DESC LIMIT 1) " +
                            "  WHERE threads._id = OLD.thread_id; "
                            "  UPDATE threads SET read = " +
                            "    CASE (SELECT COUNT(*) FROM pdu WHERE read = 0 AND old.thread_id = thread_id " +
                            "      AND (m_type=132 OR m_type=130 OR m_type=128)) " +  
                            "      WHEN 0 THEN 1 " +
                            "      ELSE 0 " +
                            "    END " +
                            "  WHERE threads._id = old.thread_id;";
    This will ensure that when the MMS comes in and is staged temporarily in the sender's thread then moves to the group, it will mark the old thread as "read" instead of leaving it stuck on "unread".


    ALSO, i was annoyed at how the timecode on the thread does not represent the LAST message in the thread but INSTEAD marks the thread date/time as the moment you last made a change to it. To fix that I made the following change:

    Original:
    Code:
            // Update threads table whenever a message in pdu is deleted
            db.execSQL("CREATE TRIGGER pdu_update_thread_on_delete " +
                       "AFTER DELETE ON pdu " +
                       "BEGIN " +
                       "  UPDATE threads SET " +
                       "     date = (strftime('%s','now') * 1000)" +
                       "  WHERE threads._id = old." + Mms.THREAD_ID + "; " +
                       UPDATE_THREAD_COUNT_ON_OLD +
                       UPDATE_THREAD_SNIPPET_SNIPPET_CS_ON_DELETE +
                       "END;");
    Modified:
    Code:
            // Update threads table whenever a message in pdu is deleted
            db.execSQL("CREATE TRIGGER pdu_update_thread_on_delete " +
                       "AFTER DELETE ON pdu " +
                       "BEGIN " +
                       "  UPDATE threads SET " +
                       "     date = (SELECT date FROM" +
                       "        (SELECT date * 1000 AS date, thread_id FROM pdu" +
                       "         UNION SELECT date, thread_id FROM sms)" +
                       "     WHERE thread_id = old." + Mms.THREAD_ID + " ORDER BY date DESC LIMIT 1)" +
                       "  WHERE threads._id = old." + Mms.THREAD_ID + "; " +
                       UPDATE_THREAD_COUNT_ON_OLD +
                       UPDATE_THREAD_SNIPPET_SNIPPET_CS_ON_DELETE +
                       "END;");

    PS I will be uploading my version of cm-10-20120912-UNOFFICIAL-toro

    Check the top post, I would love some testers and feedback.
    Thanked by:
    ohiomoto likes this.
  14. #14  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    btw, playa there is a poster over at rootzwiki, that claims this will only work between phones that are running stock messaging app on JB, is that true?
  15. Thread Author  Thread Author    #15  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    FYI,

    Euroskank wants to implement this, but has stated a comment you might want to look at:

    [CM10][Jellybro] Toro Nightly Kangs - [VZW] Galaxy Nexus Development - RootzWiki - Page 227
    SeigaGen,

    if you could please let Euroskank know that because I'm still a noob at all this, I had NO idea what I was doing on Gerrit, but I'm working on resubmitting it. I just run into a lot of issues because I'm running linux virtually off my mac.

    - - - Updated - - -

    Quote Originally Posted by kevlar924 View Post
    btw, playa there is a poster over at rootzwiki, that claims this will only work between phones that are running stock messaging app on JB, is that true?
    kevlar924,

    I'm not 100% if it will or will not work with third-party apps, but the change to the framework provides the code to thread the incoming meassage to a group and the change to the Mms.apk (stock Messaging app) provides functionality to send group messages.

    I know that some third-party apps rely on the stock messaging app to handle incoming messages, if that is the case then it should thread just fine. But those third-party apps also need to have the functionality to send group MMS messages.

    I hope I was able to answer your questions.

    EDIT: My fault, I just checked the rootzwiki post you were referring to. That is FALSE. This is a not a NEW protocol. I just changed how Android handles the standard MMS that EVERYONE uses. I have tested with Moto Droid and iPhone devices in the same convo. It works.

    or should I say it works for me. I'm hoping it works for everyone else too. But I can fix bugs as soon as people try it out and let me know what they are.
    Last edited by playa1257; 09-13-2012 at 01:02 PM.
    Thanked by:
    ohiomoto likes this.
  16. #16  
    SeigaGen's Avatar

    Posts
    624 Posts
    ROM
    Kang/CM10

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Quote Originally Posted by playa1257 View Post
    SeigaGen,

    if you could please let Euroskank know that because I'm still a noob at all this, I had NO idea what I was doing on Gerrit, but I'm working on resubmitting it. I just run into a lot of issues because I'm running linux virtually off my mac.
    Need not worry. Actually he incorporated it with his latest CM build today. Believe me when I say that you basically revolutionized the Stock Messaging App .
    Motorola Droid Maxx

    Samsung Galaxy Nexus - RIP
    CM10 Jellybro Jelly Bean

    Asus Nexus 7
    AOKP JB Milestone 1
  17. #17  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Quote Originally Posted by SeigaGen View Post
    Need not worry. Actually he incorporated it with his latest CM build today. Believe me when I say that you basically revolutionized the Stock Messaging App .
    just tried out that euroskank's CM build, sent out a group message to my roommates (all iPhones) and it worked beautifully...I can not thank you enough
  18. #18  
    AppleBonker's Avatar
    Dag, yo!

    Posts
    1,977 Posts
    ROM
    AOKP/Franco & PA/Franco

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Out of curiosity, how does it fair if an iPhone sends a group text to your phone?
  19. Thread Author  Thread Author    #19  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Quote Originally Posted by AppleBonker View Post
    Out of curiosity, how does it fair if an iPhone sends a group text to your phone?
    Just fine!

    My mod does not discriminate.
    Thanked by 4:
    SeigaGen and ohiomoto like this.
  20. #20  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    This might get me back on ES! I submitted a request for CNA to implement this. We shall see.
    ConTejas and pmcd1962 like this.
  21. #21  
    AppleBonker's Avatar
    Dag, yo!

    Posts
    1,977 Posts
    ROM
    AOKP/Franco & PA/Franco

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Excellent work, sir. Not a huge necessity for me, but definitely a handy addition. I certainly appreciate the work.
  22. #22  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Now, i don't mean to be needy, but since i've been doing all this group texting I need a way to check who theyre actually going to. (Example, it will say it goes to eric, alex, kara...) and then it will tell me it goes to 7 people but will only show the first 3. If there is a mod to click on the list and see all the recipients that would be awesome!
  23. Thread Author  Thread Author    #23  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Quote Originally Posted by kevlar924 View Post
    Now, i don't mean to be needy, but since i've been doing all this group texting I need a way to check who theyre actually going to. (Example, it will say it goes to eric, alex, kara...) and then it will tell me it goes to 7 people but will only show the first 3. If there is a mod to click on the list and see all the recipients that would be awesome!
    That's good... I'll look into it.
    Thanked by:
    ohiomoto likes this.
  24. #24  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    Is this going to be uploaded to the cm gerrit?
  25. #25  

    Default Re: Group Text Messaging for JB - ACHIEVED!

    You said you submitted this to AOSP and I'd like to track the progress of it, but I'm not seeing it, can you provide a link?

    Thanks.
Page 1 of 6 1234 ... LastLast

Similar Threads

  1. How to get out of a group text message
    By laladollaz in forum Droid RAZR MAXX
    Replies: 19
    Last Post: 02-24-2014, 11:21 AM
  2. Group Text Messaging
    By juanuby in forum Motorola Droid 3
    Replies: 5
    Last Post: 10-26-2012, 09:57 PM
  3. SMS/MMS Group Text Messaging
    By playa1257 in forum Bionic Rooting, ROMs, and Hacks
    Replies: 0
    Last Post: 12-14-2011, 03:30 PM
  4. Talk to wriiten text message for a captivate
    By andy55 in forum General Help and How To
    Replies: 2
    Last Post: 11-28-2010, 01:36 PM
  5. Text Message for 2.2
    By Tom8916 in forum Motorola Droid X
    Replies: 33
    Last Post: 10-01-2010, 11:59 AM

Posting Permissions

B