Sometimes you may have an app you want to use that's region locked so you enable mock location to trick the device into working where is not meant to work.
Also to spoof where they actually are, some people just like their privacy and don't want their devices feeding information about them to Google or anyone else.