Did you install a new ROM? You need TouchWiz for proper camera function. Or if you have TouchWiz but froze or removed something the camera is dependent on. Whatever you did, I suggest you flash back to stock and start over. If you still want to modify your phone, do things one by one and test their effects so you know where the problem is.