I have a Pixel 2 XL panda for personal and an iPhone 8 Plus for work.
As far as hardware, quality and build, I think the iPhone is quite a bit ahead of the Pixel 2 XL. As you said OP, never had to RMA a device, Apple seem to have extremely high QC standards, I feel Google's QC standard is lower.
Software and camera, I like the Pixel 2 XL more than the iPhone. To me, the Pixel 2 has a noticeably better camera and has portrait mode selfies with the bokeh effect.
Google currently doesn't have anything that competes with iMessage, and yeah it does suck, but that will supposedly be fixed in the next 12 months with RCS.
Looks like you've decided to go with the P2XL. Hope you like your decision.