In the past, I was an upgrade-every-year type. Part of that was because I used Samsung phones and wanted to upgrade to the latest OS. Last year, when the Pixel came out, it was a little better than the 6P in a few ways, but not enough to overcome its high price and homely looks.
This year, the situation is worse. The Pixel 2 XL seems to have an inferior display and lacks the 3.5mm audio port. I have 10 Bluetooth headsets. I like them better than wired headsets. But there are times you can't use them (on a plane, for example) or when the headsets you have with you have dead batteries. On my various sets, the batteries last from minimum of 2.5 hours to a max of 7.5 hours.
With my battery down to 68% of capacity, I'm definitely looking at replacing the battery, and getting another year out of my 6p. The screen is still top notch. The camera is supposedly not as good as the pixel/pixel2, but it is so good I can hardly complain. The phone is plenty fast for everything I do, and I come nowhere near filling the 64GB of memory. Aside from the battery, I feel no need to upgrade for the next year.
I guess at this point I care much more about OS upgrades than about hardware upgrades. I can't go back to Samsung (or any other maker) because I don't want to wait for OS upgrades. So I'll enjoy my audio jack for another year and hope that Bluetooth headsets have improved in the next year when I can buy a (hopefully-less-ugly) pixel 3xl.