Personally I prefer Samsung devices over Pixel phones for these reasons:
1. Software(ish). I would love to have pure Android but I also like some of the extra features you get on Samsung’s Experience/OneUI...such as the horizontal swiping app drawer and Secure Folder.
2. Design. Samsung phones have far superior designs/looks to Pixel phones, hands down. Slim bezels/hole-punch/teardrop > thicker bezels/massive notch.
3. Battery life. Samsung phones have always had good batteries in my experience, and on paper the Pixel batteries seem a bit lacklustre (apart from the 3a).
4. More value for money. You get more bang for your buck. As well as a ton of extra nice features like expandable storage, headphone jack (flagships) etc
The only thing Pixels have over Samsung is cleaner software/updates (not by much now), slightly better low light photography and that’s about it. Battery life, camera versatility, nice features and design is all better with Samsung.
Just my opinion.