I still have my Note 4 - it is my daily driver after almost two years, and I still see nothing compelling enough to move to (even if the Note 7 hadn't started the whole debacle, I was still not quite interested enough to jump for one). The combination of a still-reasonably-recent OS, S-Pen, and of course that lovely replaceable battery keep me coming back for more, even though I have a 2-year replacement available and could get anything else I wanted at a pretty substantial discount.
I usually end up swapping phones after about 6-8 months because there is always something that has features I want more. In the last two years, there has literally been NOTHING that is worth even paying discounted upgrade pricing for over my Note 4.
Obviously, different people have different tastes and desires, and that's fine. I can only speak for myself in saying that the only thing that has come close recently to replacing my Note 4 is the LG V20, and that still isn't quite enough of an upgrade to make me consider spending $350 on a subsidized upgrade...