I couldn't bear with my Pixel 3 XL's dying battery any longer - it was down to less than 2 hours SOT. As per usual, not much value offered by Google in trade, so it would've cost me almost $600 to switch to the 5. I ended up going to the S20 FE as I was able to trade it in in tandem with other promotions (no new service requirement) to a net cost of about $100, and I figure I'll be able to get far, far greater trade-in value on the Samsung when I next upgrade.
Having had the S20 FE for a week now, I'll say that it's a great piece of equipment with a fantastic display, but given the option at the same price I'd certainly opt for the Pixel 5. The gains I'm enjoying from the hardware of the S20 FE in terms of performance (noticeably but not substantially faster than 3 XL, vastly brighter display (though evidently the 5 will have that as well), and ability to maintain multiple apps running (likely to be even better with the 5, which features 1/3 more RAM than the S20 FE) are nice but due not overcome the large drop in camera quality for stills, or, most importantly, the simple IT-JUST-WORKS mentality of the Pixels that makes them so effortless. Also, in-display FPS works well enough, but I still have to consciously place a finger on it to unlock; the rear FPS is still faster, more reliable, and essentially subconscious in operation.
==========================================
With regards to the 'other' conversation in this thread, I'll chime in briefly on the concern over losing unlimited original quality photo storage as there's an alternative that may well work for you.
To anyone who uses Amazon Prime, Amazon Photos offers unlimited original resolution photo storage (including RAW), with automatic backup. They don't explicitly define whether there is or is not any compression anywhere that I could find, but in looking through reviews of the service I found several stating that they do not apply any compression, and none saying that they did, so it seems like a good alternative.
A couple of things to note that aren't quite as nice would be that: (1) Unlimited is for photos only, as video files count towards a laughable 5GB cap of free storage; and (2) Amazon's storage isn't as insanely easy to search as Google's (though you could still have everything upload at the still-free supported level for Google Photos and double-dip, plus enjoy added reassurance that even if one of the two were to have a catastrophic event where storage were lost, the other would be there - if going this route, I would definitely encourage setting at least one of the two services to only back up over WiFi, or you'll chew through your battery and data that much more swiftly).
