Point 3 is what stopped me. $335 for my 2xl 128gb was not enough. $435 and I'd have a 3xl on the way.1. My Pixel 2 XL's warranty will run out about the same time as it would for the Pixel 3/3XL were I to upgrade.
2. Many of the most enticing upgrades (to me) are still coming to the 2 XL. The nicer screen, super Rez zoom, and 600MHz band are attractive (the latter being meaningful to me as a T-Mobile user) but only made the phone worth considering, not enough to upgrade given the cost because...
3. Google shortchanged the trade-in value by a huge amount compared to last year. They are offering far less value for a Pixel 2 XL than they did for a Pixel XL last year, and upping the price at the same time. Had they even offered the same value as last year I probably would have upgraded.
Last year the timing was perfect as my daughter needed a new phone when the 2 came out so she got my OG Pixel.
Not so this year and Google with a mild upgrade and low-ball trade in value didn't make a strong case to upgrade.