I love my S10 (not the plus). It isn't too tall. It is light. I can plug in my 5 year old noise cancelling Bose headphones with a cable. I get great battery life. The only thing I don't like is the camera software processing. It takes horrible pictures of my dog. The google camera on it takes pictures almost as good as my Pixel 3a.
That being said...if the deal is right, I would jump on it. I traded in my S9+ for $550, got free Galaxy Buds, and a free $50 Leather Case from samsung (that I absolutely love!!!). So $730 worth of value for my trade-in to buy a $900 phone. Spent $370 with tax and that included the ear buds (which I was likely to buy), and a case (which I'm so glad I got...even though I would normally never spend $50 on a case).
If I can spend $400 or less each year and get the latest and greatest after trade-in and get some goodies...seems way better than waiting over a year after a phone comes out and buying an older phone for probably more and not getting freebies.